feat(spanner): add connection property for enabling/disabling grpc-gcp#12898
Merged
feat(spanner): add connection property for enabling/disabling grpc-gcp#12898
Conversation
Adds a connection property for enabling/disabling the grpc-gcp channel pool. This channel pool is the default, but can be disabled by setting this property to false. The connection will use Gax for channel pooling if grpc-gcp is disabled.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the enableGrpcGcp connection property, allowing users to explicitly enable or disable the grpc-gcp extension. The implementation updates ConnectionOptions, ConnectionProperties, and SpannerPool to handle this new configuration, including logic to ensure Dynamic Channel Pooling is only active when grpc-gcp is not disabled. Feedback suggests improving documentation to clarify the interaction between enableDynamicChannelPool and enableGrpcGcp to prevent user confusion when both are set.
rahul2393
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a connection property for enabling/disabling the grpc-gcp channel pool. This channel pool is the default, but can be disabled by setting this property to false. The connection will use Gax for channel pooling if grpc-gcp is disabled.