Skip to content

feat(spanner): add connection property for enabling/disabling grpc-gcp#12898

Merged
olavloite merged 2 commits intomainfrom
spanner-connection-enable-grpc-gcp-property
Apr 23, 2026
Merged

feat(spanner): add connection property for enabling/disabling grpc-gcp#12898
olavloite merged 2 commits intomainfrom
spanner-connection-enable-grpc-gcp-property

Conversation

@olavloite
Copy link
Copy Markdown
Contributor

Adds a connection property for enabling/disabling the grpc-gcp channel pool. This channel pool is the default, but can be disabled by setting this property to false. The connection will use Gax for channel pooling if grpc-gcp is disabled.

Adds a connection property for enabling/disabling the grpc-gcp channel pool. This channel
pool is the default, but can be disabled by setting this property to false.
The connection will use Gax for channel pooling if grpc-gcp is disabled.
@olavloite olavloite requested review from a team as code owners April 23, 2026 08:51
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the enableGrpcGcp connection property, allowing users to explicitly enable or disable the grpc-gcp extension. The implementation updates ConnectionOptions, ConnectionProperties, and SpannerPool to handle this new configuration, including logic to ensure Dynamic Channel Pooling is only active when grpc-gcp is not disabled. Feedback suggests improving documentation to clarify the interaction between enableDynamicChannelPool and enableGrpcGcp to prevent user confusion when both are set.

@olavloite olavloite enabled auto-merge (squash) April 23, 2026 09:28
@olavloite olavloite merged commit 1e633d7 into main Apr 23, 2026
123 checks passed
@olavloite olavloite deleted the spanner-connection-enable-grpc-gcp-property branch April 23, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants