Skip to content

feat: setup React hybrid widget infrastructure #16766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shuoweil wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: setup React hybrid widget infrastructure #16766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bigframes/bigframes/display/anywidget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def _on_initial_load_complete(self, change: dict[str, Any]):
@functools.cached_property
def _esm(self):
"""Load JavaScript code from external file."""
return resources.read_text(bigframes.display, "table_widget.js")
return resources.read_text(bigframes.display, "table_widget.esm.js")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request updates the code to load table_widget.esm.js, but this file is not included in the changes. As this is the bundled asset required for the widget to function, its absence will cause a FileNotFoundError at runtime.


@functools.cached_property
def _css(self):
Expand Down
24 changes: 24 additions & 0 deletions packages/bigframes/bigframes/display/react-dom.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 16 additions & 0 deletions packages/bigframes/bigframes/display/react.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions packages/bigframes/bigframes/display/scheduler.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading