refactor: Unify gbq execution as semi-executor#16770
Draft
TrevorBergeron wants to merge 4 commits intomainfrom
Draft
refactor: Unify gbq execution as semi-executor#16770TrevorBergeron wants to merge 4 commits intomainfrom
TrevorBergeron wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigFrames execution framework by replacing CacheSpec with TempTableSpec and restructuring BigQueryCachingExecutor to use a recursive _execute_bigquery method. The DirectGbqExecutor was also updated to handle the new ExecutionSpec. Several critical issues were identified in the refactored code, including missing attributes in DirectGbqExecutor (storage_manager, bqstoragereadclient, _labels, and metrics), a missing publisher argument in its constructor call, and an invalid lifetime field usage in TableOutputSpec. Furthermore, the DirectGbqExecutor currently ignores its configured compiler function, which will lead to incorrect behavior when a custom compiler is provided.
| return executor.BQTableExecuteResult( | ||
| data=result_bq_data, | ||
| project_id=self.bqclient.project, | ||
| storage_client=self.bqstoragereadclient, |
Contributor
076cb98 to
e239b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕