chore: regenerate all libraries while ignoring overrides#16776
chore: regenerate all libraries while ignoring overrides#16776jskeet wants to merge 4 commits intogoogleapis:mainfrom
Conversation
(Note: client_documentation overrides are still applied.) This is for initial review only. Towards googleapis/librarian#4175
jskeet
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes metadata and documentation across a wide range of Google Cloud Python client packages, including updates to product names, documentation URLs, and issue tracker links. The review feedback identifies specific regressions where product names were inadvertently removed from documentation headers and overview text in the App Engine Logging package. Additionally, it is recommended to maintain the specific documentation path for Apigee Connect rather than reverting to a general landing page to preserve the utility of the metadata.
| ]: # | ||
|
|
||
| # App Engine Logging Protos API | ||
| # API |
There was a problem hiding this comment.
The header is missing the product name due to the metadata changes.
| # API | |
| # App Engine Logging API |
| # API | ||
|
|
||
| Overview of the APIs available for App Engine Logging Protos API. | ||
| Overview of the APIs available for API. |
There was a problem hiding this comment.
The product name is missing from the overview text.
| Overview of the APIs available for API. | |
| Overview of the APIs available for App Engine Logging API. |
| "name": "google-cloud-apigee-connect", | ||
| "name_pretty": "Apigee Connect", | ||
| "product_documentation": "https://cloud.google.com/apigee/docs/hybrid/v1.4/apigee-connect", | ||
| "product_documentation": "https://cloud.google.com/apigee/", |
There was a problem hiding this comment.
The product_documentation URL has been changed to a less specific landing page compared to the previous specific documentation path. This reduces the utility of the metadata.
| "product_documentation": "https://cloud.google.com/apigee/", | |
| "product_documentation": "https://cloud.google.com/apigee/docs/hybrid/v1.4/apigee-connect", |
|
Note: when we do eventually want to do this, we should wait for other changes to librarian.yaml to be made first. |
|
Note: for anything non-Python-specific where information is missing or wrong, we should add it to sdk.yaml in the librarian repo. I'm happy to do that; just add a comment. I'd suggest ignoring .repo-metadata.json files as they don't have an impact beyond what happens for doc generation etc. If it would be helpful, I can add a commit that restores all the .repo-metadata.json files so that it's easier to see the real changes. |
daniel-sanche
left a comment
daniel-sanche
left a comment
There was a problem hiding this comment.
Most of the changes look reasonable. But it looks like gemini caught some problems. And doing a few random spot-checks on new docs URLs, I'm seeing some broken links
Do you know how those links are handled in other languages?
| "api_id": "beyondcorp.googleapis.com", | ||
| "api_shortname": "beyondcorp", | ||
| "client_documentation": "https://cloud.google.com/python/docs/reference/beyondcorpappgateways/latest", | ||
| "client_documentation": "https://cloud.google.com/python/docs/reference/google-cloud-beyondcorp-appgateways/latest", |
There was a problem hiding this comment.
Just looked at this one at random, but it looks like the old link worked, but the new one is broken
There was a problem hiding this comment.
That's odd - I didn't think my change even removed client_documentation_uri overrides - I'll need to check that tomorrow. This part is language-specific, and I hadn't expected to remove those overrides, at least not to start with.
| .. _Product Documentation: https://cloud.google.com/python/docs/reference/certificatemanager/latest | ||
| .. _Certificate Manager: https://cloud.google.com/python/ | ||
| .. _Client Library Documentation: https://cloud.google.com/python/docs/reference/google-cloud-certificate-manager/latest/summary_overview | ||
| .. _Product Documentation: https://cloud.google.com/python/ |
2 participants
Creating as a draft with "do not merge"; this is only for review purposes.