feat: add uri property to Bucket and Blob for roundtrip consistency#16782
Open
guillaume-rochette-oxb wants to merge 5 commits intogoogleapis:mainfrom
Open
feat: add uri property to Bucket and Blob for roundtrip consistency#16782guillaume-rochette-oxb wants to merge 5 commits intogoogleapis:mainfrom
guillaume-rochette-oxb wants to merge 5 commits intogoogleapis:mainfrom
Conversation
… consistency with the class method `from_uri`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
guillaume-rochette-oxb
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a uri property to the Blob and Bucket classes, along with corresponding unit tests. The review feedback suggests adding validation to ensure that the name attribute is not None before constructing the URI, which prevents the generation of invalid URI strings and ensures fail-fast behavior.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This Pull Requests fixes #15984.
I have added the documentation, added necessary assertions in the tests, and the code coverage should be maintained.
Best regards,
Guillaume