Handle missing output field in Ethereum trace results#6495
Open
JunaidCD wants to merge 1 commit intographprotocol:masterfrom
Open
Handle missing output field in Ethereum trace results#6495JunaidCD wants to merge 1 commit intographprotocol:masterfrom
JunaidCD wants to merge 1 commit intographprotocol:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Graph Node fails to deserialize traces when the
result.outputfield is missing.This occurs for certain trace types (e.g.
suicide) where the RPC response legitimately omits theoutputfield, leading to errors like:data did not match any variant of untagged enum TraceOutput
Cause
After switching to alloy, the
outputfield is treated as required during deserialization, while some valid traces do not include it.Solution
Before deserialization, a default value ("0x") is inserted when the
outputfield is missing.Scope
ethereum_adapter.rsImpact
Prevents indexing failures for chains that return traces without
output, restoring compatibility with existing RPC behavior.