Fix flakey authentication in webkit e2e tests#65642
Open
Fix flakey authentication in webkit e2e tests#65642
Conversation
ryanclark
added
the
no-changelog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 005fb9bfc4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the running of e2e tests in CI to run at maximum two instances of teleport/tests at any one time. Before, we'd run all 4 (webkit/chromium/firefox/connect) Teleport instances and test suites at once, which would cause the webkit authentication setup test to sometimes take longer than 20 seconds and fail. By limiting the number of things running at a time, this test should run much more quickly.
Also removes the
networkidleassertion from the login helper, as we assert on seeing "Resources" in the UI after that anyway.networkidlecan also be something that Safari takes a while to fully resolve, further making the test take longer.Closes #65563
Manual Test Plan
Test Environment
CI
Test Cases