Merged
Conversation
- remove local-mounts feature - add dotfiles-sync for merging config files - create sync script with merge strategy - add installation and runtime detection scripts - implement tests for dotfiles-sync functionality
…ation - update supported platforms in README - improve merge strategy for cloud environments in sync script - clarify GPG signing behavior on cloud platforms
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-04-17 |
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing local-mounts devcontainer feature with a new dotfiles-sync feature that syncs developer dotfiles into the container using a merge (non-destructive) strategy and adds environment-aware behavior for cloud dev environments.
Changes:
- Removed the
local-mountsfeature (scripts, metadata, docs, and test). - Added the new
dotfiles-syncfeature (install + runtime sync scripts, devcontainer feature definition, docs, and tests). - Updated repository docs and CI matrices / conventional-commit scopes to reference
dotfiles-sync.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/local-mounts/test.sh | Removed local-mounts feature test script. |
| test/dotfiles-sync/test.sh | Added test script validating dotfiles-sync installation and runtime artifacts. |
| src/local-mounts/sync-files.sh | Removed legacy runtime sync implementation. |
| src/local-mounts/install.sh | Removed legacy build-time installer. |
| src/local-mounts/devcontainer-feature.json | Removed feature definition for local-mounts. |
| src/local-mounts/README.md | Removed feature documentation for local-mounts. |
| src/dotfiles-sync/sync-files.sh | Added environment-aware merge-based sync logic for git/ssh/npm/gpg. |
| src/dotfiles-sync/install.sh | Added feature installer that provisions directories and installs runtime/profile.d scripts. |
| src/dotfiles-sync/devcontainer-feature.json | Added new feature definition + options + mounts + postStartCommand. |
| src/dotfiles-sync/README.md | Added documentation describing merge strategy and platform behavior. |
| README.md | Updated top-level docs to list dotfiles-sync and mark local-mounts removed; updated some feature links. |
| AGENTS.md | Updated conventional-commit scopes and the feature list to include dotfiles-sync. |
| .github/workflows/test.yml | Added dotfiles-sync to CI feature test matrix. |
| .github/workflows/pr-validation.yml | Added dotfiles-sync to validation scopes and test matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- create directories for SSH, GPG, gitconfig, and npmrc - update README and feature JSON to remove override options - improve error messages in sync script
- add git availability check for smart merge - improve test script output for git availability
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
src/dotfiles-sync/devcontainer-feature.json:34
mountsbind-mounts~/.gitconfig,~/.ssh,~/.gnupg, and~/.npmrcunconditionally. On Docker, a bind mount typically fails container startup if the host path doesn’t exist (and many users won’t have~/.gnupgor~/.npmrc). Consider changing the mounting approach to avoid hard failures (e.g., mount only$HOME/a staging dir, or document clearly that these paths must exist before starting the container).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baxyz
force-pushed
the
new-dotfiles-sync
branch
from
a185822 to
8a33785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.