Add item_model data component support for tokens#123
Open
PurpleGale wants to merge 1 commit intohyperdefined:masterfrom
Open
Add item_model data component support for tokens#123PurpleGale wants to merge 1 commit intohyperdefined:masterfrom
PurpleGale wants to merge 1 commit intohyperdefined:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Minecraft
item_modeldata component (introduced in 1.21.4) to the token system, while fully preserving the existingcustom_model_datafunctionality.Changes
TokenData.java— Reads the newitem-modelconfig block and applies it viaDataComponentTypes.ITEM_MODELusing a validatedNamespacedKey.config.yml— Addsitem-model.enabledanditem-model.valueunder every token entry.ToolStats.java— BumpsCONFIG_VERSIONfrom17to18.ConfigUpdater.java— Wires up the17 → 18migration path.Version18.java(new) — Config updater that injectsitem-modeldefaults into existing user configs during automatic migration.Backward Compatibility
custom-model-databehavior is completely untouched.custom-model-dataanditem-modelcan be used independently or together.Usage Example