Expand claude md with TDD and other config#24
Closed
BertVermorgen wants to merge 99 commits intomasterfrom
Closed
Conversation
Added a new section for 'SkillForge' in the README.
Added preparation details for BackOffice and Consultants.
Essential non-inferrable context only: Docker prerequisite, bun package manager, and pre-commit checklist. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Update .gitignore to share .claude/commands (keep settings.local.json ignored) - Add /pr command that creates PR and posts AI code review to GitHub Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add /pr workflow for AI-assisted pull requests
Add instructions for using gh api to post comments on specific lines of code, with examples of common issues to flag. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- If uncommitted changes exist, offer to commit with suggested message - If on master, suggest branch name and create it - Uses AskUserQuestion to guide user through the process Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Created a new Product Requirements Document (prd.md) detailing the SkillForge platform's features, user journeys, success criteria, and non-functional requirements. - Added a Product Brief (product-brief-Bootcamp-AI-2026-02-27.md) outlining the core vision, target users, success metrics, and MVP scope for SkillForge. - Introduced two skill matrices (Developer_Skill_Experience_Matrix.xlsx and Skill_Matrix_Itenium.xlsx) to support the global skill catalogue for the platform.
Remove manual docker pull
Add cd to Itenium.SkillForge project
Member
|
Hey Bert, Ik ga deze niet mergen. Te veel tekst in CLAUDE.md |
Contributor
Author
|
Claude code wat laten opsplitsen, morgen kijken of dit beter kan. |
Laoujin
reviewed
Mar 11, 2026
|
|
||
| @.claude/architecture.md | ||
| @.claude/tdd.md | ||
| @.claude/frontend.md |
Laoujin
reviewed
Mar 11, 2026
| - Write **human-readable code**: intention-revealing names, small focused functions, no clever tricks. | ||
| - **DRY and SOLID apply strictly to production code.** Tests may duplicate setup/data/assertions — never sacrifice test clarity for abstraction. | ||
| - Prefer **explicit over implicit**: no magic, no hidden conventions, no surprising side effects. | ||
| - Keep the **domain model pure**: no framework annotations, no ORM attributes, no HTTP concerns inside domain or application layers. |
Member
There was a problem hiding this comment.
Deze zou ik weglaten, dat is er al vanuit gaan dat de teams zo willen werken
De andere 3 zijn wss wel goed idee
Laoujin
reviewed
Mar 11, 2026
|
|
||
| ``` | ||
| bun run lint && bun run typecheck && bun run test | ||
| dotnet format && dotnet test |
Member
There was a problem hiding this comment.
Deze is van mij, maar is eigenlijk ook een anti-pattern
- husky regelt dit momenteel :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #22