solve issue #2707 (software skinning requires mesh normals)#2708
Open
stephengold wants to merge 2 commits intomasterfrom
Open
solve issue #2707 (software skinning requires mesh normals)#2708stephengold wants to merge 2 commits intomasterfrom
stephengold wants to merge 2 commits intomasterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the copyright year and introduces null checks for the normal buffer in SkinningControl.java to prevent potential null pointer exceptions when skinning meshes without normals. A review comment suggests refining the condition for updating the normal buffer to check for the data buffer's presence instead of just the vertex buffer to avoid redundant GPU uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds null checks in SkinningControl.java to allow animated meshes without normals to use software skinning in the new animation system.
Animated meshes without normals are probably rare, so I didn't make any effort to optimize the loop for that case.
I tested this code on the test app from issue #2707, and it ran without crashing, so this PR should solve issue #2707.
I also tested the same app with hardware skinning preferred, and it ran without crashing, so there doesn't seem to be any corresponding issue for hardware skinning.