Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b9f417628
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| dynsym_names = dynsym.body.map(&:name_string) | ||
| assert_equal(1, needed.size) | ||
| assert_equal(dynstr.body.lookup(needed.first.un), "libc.so.6") | ||
| assert_include(dynsym_names, "_exit") |
There was a problem hiding this comment.
_exit assertion from dynsym checks
These new assertions make the test suite fail against the current linker implementation because _exit is an undefined import in start.o, and the builder only exports defined symbols to .dynsym (next if sym.shndx == 0 in Caotral::Linker::Builder). As written, test_start_in_dynamic_section (and the same check later in test_start_in_shared_object) will fail even when DT_NEEDED handling is correct, turning this feature test into a persistent false negative.
Useful? React with 👍 / 👎.
1 participant
add test for needed section