Add tests and improve documentation for zero reserve channels#873
Add tests and improve documentation for zero reserve channels#873tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
|
Let me know how this sounds, is that the testing you had in mind ? |
|
vss tests don't compile but yeah lgtm |
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
d3e3e57 to
f832421
Compare
|
Fixed the VSS tests, and reworked the documentation wording |
|
🔔 1st Reminder Hey @tnull @benthecarman! This PR has been waiting for your review. |
1 similar comment
|
🔔 1st Reminder Hey @tnull @benthecarman! This PR has been waiting for your review. |
| .unwrap(); | ||
| if allow_0reserve { | ||
| node_a | ||
| .open_0reserve_channel( |
There was a problem hiding this comment.
That's fine, but should we also assert that we can spend the full channel balance now that both coutnerparties set 0reserve for each other?
There was a problem hiding this comment.
thank you see below. A caveat is that we don't have an API yet for the opener of the channel to get 0-reserve.
src/lib.rs
Outdated
| /// This channel allows the target node to try to steal your funds with no financial | ||
| /// penalty, so this channel should only be opened to nodes you trust. | ||
| /// The target node may have nothing at stake if it tries to steal your funds in this | ||
| /// channel, so only open this channel to nodes you trust. |
There was a problem hiding this comment.
That 'only open this channel to nodes you trust' part is odd. There will only be one channel, there isn't the potential to open this one channel to multiple nodes/other nodes, just the one we're opening to...
FWIW, I preferred the previous version honestly.
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
f832421 to
6fe0808
Compare
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
6fe0808 to
46ce6b3
Compare
tankyleo
force-pushed
the
2026-04-zero-reserve
branch
from
46ce6b3 to
da6525a
Compare
4 participants
Follow-up to #853