Skip to content

fix(grid-visualizer): add missing bankName field to COP_ACCOUNT#380

Open
claude[bot] wants to merge 1 commit intomainfrom
docs/sync-20260423
Open

fix(grid-visualizer): add missing bankName field to COP_ACCOUNT#380
claude[bot] wants to merge 1 commit intomainfrom
docs/sync-20260423

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented Apr 23, 2026

Summary

  • Adds the required bankName field to COP_ACCOUNT in the Grid Visualizer account-types data
  • The OpenAPI schema (CopAccountInfoBase.yaml) requires bankName as a mandatory field, but it was missing from the visualizer

Context

Recent schema changes (commit 13664f1) added bankName to COP_ACCOUNT as a required field. The Grid Visualizer was not updated to reflect this, which would cause generated API calls to fail.

Test plan

  • Verify Grid Visualizer code generator produces valid COP_ACCOUNT payloads with bankName field

🤖 Generated with Claude Code

The CopAccountInfoBase schema requires bankName as a mandatory field,
but it was missing from the Grid Visualizer account-types data.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude claude Bot requested review from pengying and shreyav April 23, 2026 08:43
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 23, 2026 8:44am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 23, 2026

Greptile Summary

Adds the missing bankName field to the COP_ACCOUNT entry in the Grid Visualizer's account-types.ts, bringing it in sync with the required fields declared in CopAccountInfoBase.yaml. The example value (Bancolombia) is realistic and the field is inserted in the correct schema order.

Confidence Score: 5/5

Safe to merge — single-line addition that corrects a schema drift with no logic changes.

The change is minimal, directly verified against the OpenAPI schema, and fixes a real gap that would have caused generated payloads to fail validation. No P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
components/grid-visualizer/src/data/account-types.ts Adds missing required bankName field to COP_ACCOUNT entry, aligning the visualizer with the OpenAPI schema requirement.

Sequence Diagram

sequenceDiagram
    participant User as Grid Visualizer User
    participant GV as Grid Visualizer
    participant API as Grid API

    User->>GV: Select COP_ACCOUNT type
    GV->>GV: Load account-types.ts spec (accountNumber, bankAccountType, bankName, phoneNumber)
    GV->>User: Render form with all required fields
    User->>GV: Fill in form (including bankName)
    GV->>API: POST /payments with COP_ACCOUNT payload
    API->>API: Validate against CopAccountInfoBase schema (bankName: required)
    API->>User: 200 OK
Loading

Reviews (1): Last reviewed commit: "fix(grid-visualizer): add missing bankNa..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants