round af/rx-/txdelay to 3 decimal places#2001
Open
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Open
round af/rx-/txdelay to 3 decimal places#2001weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
weebl2000 wants to merge 1 commit intomeshcore-dev:devfrom
Conversation
weebl2000
force-pushed
the
nit-float-rounding-cli
branch
from
eb283cb to
f6eecfb
Compare
weebl2000
force-pushed
the
nit-float-rounding-cli
branch
from
f6eecfb to
9c6aeb2
Compare
Contributor
Author
|
@liamcottle thoughts? |
weebl2000
force-pushed
the
nit-float-rounding-cli
branch
from
9c6aeb2 to
4d166ec
Compare
This avoids seeing 0.1999999 for direct.txdelay 0.2 :)
weebl2000
force-pushed
the
nit-float-rounding-cli
branch
from
4d166ec to
0e578b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor nit to fix this:
7 decimals precision is required for frequency get/set but not so relevant for the delays/af etc.