Fix investigate-security protocol mismatch breaking CI#246
Merged
Alan-Jowett merged 2 commits intomicrosoft:mainfrom Apr 14, 2026
Merged
Conversation
Remove inline YAML comment from investigate-security.md frontmatter that the lightweight YAML parsers were not stripping, causing 'exhaustive-path-tracing' to be parsed as 'exhaustive-path-tracing # optional — apply selectively to parser/decoder functions'. Also harden both validate-manifest.py and validate-graph-integrity.py to strip inline YAML comments from list items, preventing similar issues in the future. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes CI failures caused by inline YAML comments in template frontmatter being interpreted as part of protocol names by lightweight frontmatter parsers.
Changes:
- Removes the inline YAML comment from
templates/investigate-security.mdprotocol list. - Adds inline-comment stripping for multi-line list items in
tests/validate-manifest.py. - Applies the same hardening in
tests/validate-graph-integrity.py.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/investigate-security.md | Removes inline YAML comment that broke protocol-name matching in CI checks. |
| tests/validate-manifest.py | Strips inline YAML comments from parsed list item values to prevent mismatches. |
| tests/validate-graph-integrity.py | Same comment-stripping logic to harden template frontmatter parsing. |
Address PR review feedback: replace regex that treats any # as a comment delimiter with re.split(r'\s+#', ...) which only strips # when preceded by whitespace, matching YAML comment semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI is failing on both
validate-manifest.pyandvalidate-graph-integrity.pybecause theinvestigate-securitytemplate frontmatter contains an inline YAML comment that the lightweight parsers don't strip:The parsers treat the entire line (including the comment) as the protocol name, causing mismatches.
Fix
templates/investigate-security.md— Removed the inline comment (the information is already documented in the template body at lines 93-94)tests/validate-manifest.py— Added inline comment stripping for multi-line list itemstests/validate-graph-integrity.py— Same hardeningValidation
Both
python tests/validate-manifest.pyandpython tests/validate-graph-integrity.pypass after this change.