Skip to content

add CI description to contributing guide#13837

Open
CarinaFo wants to merge 4 commits intomne-tools:mainfrom
CarinaFo:update_contributing
Open

add CI description to contributing guide#13837
CarinaFo wants to merge 4 commits intomne-tools:mainfrom
CarinaFo:update_contributing

Conversation

@CarinaFo
Copy link
Copy Markdown
Contributor

@CarinaFo CarinaFo commented Apr 11, 2026

This PR updates the Contributing Guide to improve clarity and usability of the CI (Continuous Integration) section.

The current contributing guide links to a Wikipedia page on CI but does not explain why we use CI.

This update aims to make it easier for new contributors to:

Understand what CI is doing and why it is important to run checks locally before pushing changes. This is particularly relevant, as we receive many user comments about CircleCI and failing doc builds for unregistered users.

@CarinaFo CarinaFo marked this pull request as draft April 11, 2026 06:35
@CarinaFo CarinaFo force-pushed the update_contributing branch from 4ea778c to b1b8b9e Compare April 11, 2026 08:58
@CarinaFo
Copy link
Copy Markdown
Contributor Author

CI failure seems unrelated (PyVista/VTK on Python 3.13).

Comment thread doc/development/contributing.rst
@CarinaFo CarinaFo closed this Apr 18, 2026
@CarinaFo CarinaFo deleted the update_contributing branch April 18, 2026 04:29
@CarinaFo CarinaFo restored the update_contributing branch April 18, 2026 04:29
@CarinaFo CarinaFo reopened this Apr 18, 2026
@CarinaFo CarinaFo marked this pull request as ready for review April 18, 2026 06:43

If you are contributing for the first time, you may notice that `Github Actions`_
jobs do not start automatically, or appear as "pending".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line, make these all one paragraph

- Github Actions jobs may remain in a *pending* or *not running* state
- This does **not** indicate a problem with your code

Once a maintainer approves your pull request, Github Actions workflows will run.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut this sentence

- This does **not** indicate a problem with your code

Once a maintainer approves your pull request, Github Actions workflows will run.
Future contributions will not require manual approval.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you have at least one PR merged into the MNE-Python repository, future ...

Once a maintainer approves your pull request, Github Actions workflows will run.
Future contributions will not require manual approval.

`CircleCI`_ requires to sign up for an account and link it with your github repository
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI will not build our documentation unless the GitHub account of the PR's most recent commit is associated with a CircleCI account. Creating one is easy and free, choose "login with GitHub" on to get started.

`CircleCI`_ requires to sign up for an account and link it with your github repository
that you use to contribute to MNE-Python.

The tests will fail if you are not a registered user before you push your changes.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do not do this, it will show up as a failing CI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants