FIX: correct label orientation for 0-90 deg nodes in plot_connectivity_circle#13855
FIX: correct label orientation for 0-90 deg nodes in plot_connectivity_circle#13855paavalipopov wants to merge 10 commits intomne-tools:mainfrom
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
|
It looks like this branch includes several unrelated commits or working-tree changes. Could you reset/rebase the branch onto current main and recommit just the relevant files? Based on the commit history, three commits are unrelated to the current work |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
7e49ef8 to
f96ce9f
Compare
|
Hey @paavalipopov Can you please create a CircleCI account by signing into CircleCI via GitHub? After that you can push a commit here, and the documentation build job should run. |
CarinaFo
left a comment
There was a problem hiding this comment.
Thank you and congrats to your first PR, looks good to me.
|
Thanks for the review and the help with the cleanup, @CarinaFo! Glad to contribute to mne tools. |
drammock
left a comment
There was a problem hiding this comment.
thanks @paavalipopov this is a nice PR. Thanks for the thorough test. I have a couple of suggestions to tidy it a bit, which I think should be uncontroversial so I'll apply them and mark for merge.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
for more information, see https://pre-commit.ci
Reference issue (if any)
What does this implement/fix?
In
mne.viz.circle._plot_connectivity_circle, the condition on line 341if angle_deg >= 270that determines labels horizontal alignment only covers the 270–360° range (3–6 o'clock). Nodes in the 0–90° range (12–3 o'clock) are incorrectly treated as left-half nodes, and their labels appear pointing inward, which looks like a bug.Fix: extend the condition to
angle_deg >= 270orangle_deg < 90, matching the full right half of the circle.Additional information
Here's a visual comparison of connectograms generated using the original ("old") and patched ("new") versions of mne-tools.