FIX: Correct fNIRS interpolation with reordered picks#13856
Merged
larsoner merged 8 commits intomne-tools:mainfrom Apr 23, 2026
Merged
FIX: Correct fNIRS interpolation with reordered picks#13856larsoner merged 8 commits intomne-tools:mainfrom
larsoner merged 8 commits intomne-tools:mainfrom
Conversation
Kallemakela
requested review from
agramfort,
drammock,
larsoner and
mscheltienne
as code owners
larsoner
approved these changes
Apr 23, 2026
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
I'll commit and mark for merge-when-green, thanks in advance @Kallemakela !
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13857.
What does this implement/fix?
Fixes an indexing bug in
_interpolate_bads_nirsBefore this change,
_interpolate_bads_nirsmixed up channel indices in the underlying raw object and a local distance matrix when fNIRS channels were reordered by_validate_nirs_info(). This resulted in interpolation based on wrong channels.This fix maps raw object indices to local distance matrix indices when reading and writing data.