fix(android): cast compressionLevel to int in switch statement#342
Open
FerRiv3ra wants to merge 1 commit intomockingbot:masterfrom
Open
fix(android): cast compressionLevel to int in switch statement#342FerRiv3ra wants to merge 1 commit intomockingbot:masterfrom
FerRiv3ra wants to merge 1 commit intomockingbot:masterfrom
Conversation
Java does not support switch on double values. Casting to int is safe since all valid compression level values (-1, 0-9) are whole numbers passed from JS. Fixes mockingbot#341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java does not support
switchondoublevalues — onlyint,char,byte,short,String, and enums are valid selector types.getCompressionLevel(double compressionLevel)usesswitch (compressionLevel)which fails to compile with newer JDK/AGP versions:The fix casts to
intbefore the switch. This is safe since all valid values (-1,0–9) are whole numbers passed from JS.Fixes #341