fix: make UrlElicitationRequiredError pickle-safe#2439
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: make UrlElicitationRequiredError pickle-safe#2439Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Add __reduce__ method so pickle reconstructs with the correct (elicitations, message) arguments instead of the (code, message, data) tuple stored in Exception.args. Closes modelcontextprotocol#2431 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UrlElicitationRequiredErrorfails to unpickle becauseMCPErrorstores(code, message, data)inException.argsbutUrlElicitationRequiredError.__init__expects(elicitations, message=None), causing aTypeErroron unpickle__reduce__method toUrlElicitationRequiredErrorso pickle reconstructs with the correct(elicitations, message)argumentsMCPErrorandUrlElicitationRequiredErrorCloses #2431
Test plan
MCPErrorUrlElicitationRequiredError(single elicitation, custom message)UrlElicitationRequiredError(multiple elicitations, default message)