Skip to content

Fix Intel Mac binary not found: afterPack copies wrong arch binaries in cross-arch builds #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −1
Draft

Fix Intel Mac binary not found: afterPack copies wrong arch binaries in cross-arch builds #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b473189
Initial plan
Copilot Apr 12, 2026
2bf9c83
Fix Issue #72: use target arch from context in afterPack to fix Intel…
Copilot Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion scripts/build_optimize.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
const common = require("./common.cjs");

// electron-builder Arch enum values
const ARCH_X64 = 1;
const ARCH_ARM64 = 3;

const archFromContext = (contextArch) => {
switch (contextArch) {
case ARCH_X64: return "x86"; // x64 -> x86 (matches directory naming convention)
case ARCH_ARM64: return "arm64";
default: return common.platformArch();
}
};

console.log("BuildOptimize", {
name: common.platformName(),
arch: common.platformArch(),
Expand All @@ -12,7 +24,9 @@ exports.default = async function (context) {
});
// copy extra electron/resources/extra/[name]-[arch] to extra
const platformName = common.platformName();
const platformArch = common.platformArch();
// Use target architecture from context to support cross-arch builds
// (e.g. building x64 and arm64 on the same ARM64 machine)
const platformArch = archFromContext(context.arch);
const name = platformName + "-" + platformArch;

const srcDir = `electron/resources/extra/${name}`;
Expand Down