Allow demo users to connect to any institution in non-production environments

[mwclemy]

No description provided.

[wesrisenmay-mx]

Why do we want this feature?

[mwclemy]

Why do we want this feature?

We only want to restrict demo users from connecting to live institutions (i.e. production institutions). In lower environments, they should still be able to connect to institutions like Gringotts in Sand and QA, or any other institutions in those environments. This also helps with testing in testdrive either manually or through automated tests.

[wesrisenmay-mx]

Why do we want this feature?

We only want to restrict demo users from connecting to live institutions (i.e. production institutions). In lower environments, they should still be able to connect to institutions like Gringotts in Sand and QA, or any other institutions in those environments. This also helps with testing in testdrive either manually or through automated tests.

Won't this break the E2E test you wrote, because it will only block things in prod?

[mwclemy]

Why do we want this feature?

We only want to restrict demo users from connecting to live institutions (i.e. production institutions). In lower environments, they should still be able to connect to institutions like Gringotts in Sand and QA, or any other institutions in those environments. This also helps with testing in testdrive either manually or through automated tests.

Won't this break the E2E test you wrote, because it will only block things in prod?

Yeah, I will have to update the E2E test as well. Otherwise it would fail.

[ash-wright123]

LGTM - but you will need to update the cypress tests that were testing for this is there way to test with prod to make sure that it still works the way we want it to?

[mwclemy]

LGTM - but you will need to update the cypress tests that were testing for this is there way to test with prod to make sure that it still works the way we want it to?

Testing in prod would be difficult unless done manually through testdrive, since we don’t run our E2E tests against prod, which isn’t ideal. I’m still thinking through a better way to cover this with automated tests in Sand and QA.

[wesrisenmay-mx]

LGTM - but you will need to update the cypress tests that were testing for this is there way to test with prod to make sure that it still works the way we want it to?

Testing in prod would be difficult unless done manually through testdrive, since we don’t run our E2E tests against prod, which isn’t ideal. I’m still thinking through a better way to cover this with automated tests in Sand and QA.

Clement and I discussed via huddle yesterday. Ideally we don't have to make this change. I don't know what all it takes to create a duplicate institution, but if we could create a duplicate of MXCU that is a demo institution, then it's easy to run E2E tests and test things locally.