Skip to content

fix: filter out intentional user-input errors from error-reporting-lamda#8188

Merged
khendrikse merged 1 commit intomainfrom
EX-2080/filter-out-intentional-user-input-errors-in-lambda
Apr 22, 2026
Merged

fix: filter out intentional user-input errors from error-reporting-lamda#8188
khendrikse merged 1 commit intomainfrom
EX-2080/filter-out-intentional-user-input-errors-in-lambda

Conversation

@khendrikse
Copy link
Copy Markdown
Contributor

@khendrikse khendrikse commented Apr 22, 2026

🎉 Thanks for submitting a pull request! 🎉

Summary

A follow up to this PR to also filter from within the lambda


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested review from a team as code owners April 22, 2026 09:51
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5e51821b-b086-4403-aa71-25e20722af90

📥 Commits

Reviewing files that changed from the base of the PR and between acaf478 and 2c6882d.

📒 Files selected for processing (1)
  • site/netlify/functions/error-reporting.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved error detection to identify and properly handle user input validation errors separately from system errors.

Walkthrough

The error-reporting handler is enhanced to detect and filter user-input errors. A new USER_INPUT_ERROR_MESSAGE_PATTERNS constant defines patterns for identifying user input errors, and an isUserInputError(message) function checks whether an error message matches these patterns. When the handler processes incoming error reports, it now checks the parsed JSON message field against these patterns and returns a 200 status code early without notifying Bugsnag if a match is found. All other error handling logic remains unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: filtering out intentional user-input errors from the error-reporting lambda function.
Description check ✅ Passed The description is related to the changeset, mentioning it as a follow-up to a previous PR to filter user-input errors from within the lambda.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch EX-2080/filter-out-intentional-user-input-errors-in-lambda

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

📊 Benchmark results

Comparing with acaf478

  • Dependency count: 1,061 (no change)
  • Package size: 355 MB (no change)
  • Number of ts-expect-error directives: 356 (no change)

@khendrikse khendrikse merged commit b5b60e3 into main Apr 22, 2026
104 of 106 checks passed
@khendrikse khendrikse deleted the EX-2080/filter-out-intentional-user-input-errors-in-lambda branch April 22, 2026 11:00
sean-roberts pushed a commit that referenced this pull request Apr 22, 2026
🤖 I have created a release *beep* *boop*
---


## [25.2.0](v25.1.1...v25.2.0)
(2026-04-22)


### Features

* use database as primary name for new db subcommands
([#8176](#8176))
([40e56cf](40e56cf))


### Bug Fixes

* don't cause fatal issues when doing update checks inside of agent
sandbox ([#8186](#8186))
([acaf478](acaf478))
* filter out intentional user-input errors from error-reporting-lamda
([#8188](#8188))
([b5b60e3](b5b60e3))
* improve reliability of anon deploys
([#8170](#8170))
([95b5e52](95b5e52))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants