Conversation
Follow-up to #75 — the reusable workflow [netresearch/.github#19][org-pr] has merged to main, so drop the temporary @feat/python-audit-workflow pin. [org-pr]: netresearch/.github#19 Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Dependency ReviewThe following issues were found:
License Issues.github/workflows/security.yml
OpenSSF Scorecard
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 66.87% 66.78% -0.10%
==========================================
Files 21 21
Lines 3230 3230
==========================================
- Hits 2160 2157 -3
- Misses 1070 1073 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Security GitHub Actions workflow to consume the upstream reusable python-audit.yml workflow from netresearch/.github main branch now that the workflow has been merged upstream.
Changes:
- Switch
.github/workflows/security.ymlfrompython-audit.yml@feat/python-audit-workflowtopython-audit.yml@main. - Remove temporary inline comments related to the previous feature-branch pin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Pinned to feat/python-audit-workflow until netresearch/.github#19 merges. | ||
| # Switch to @main after merge. | ||
| uses: netresearch/.github/.github/workflows/python-audit.yml@feat/python-audit-workflow | ||
| uses: netresearch/.github/.github/workflows/python-audit.yml@main |
There was a problem hiding this comment.
uses: ...@main references a mutable branch for a reusable workflow. For supply-chain safety and reproducibility, prefer pinning to an immutable ref (a release tag or a full commit SHA in netresearch/.github) and optionally keep it updated via Dependabot/renovate.
| uses: netresearch/.github/.github/workflows/python-audit.yml@main | |
| uses: netresearch/.github/.github/workflows/python-audit.yml@<FULL_40_CHAR_COMMIT_SHA> |
Follow-up to #75. The reusable
python-audit.ymlworkflow merged into netresearch/.github main, so drop the temporary@feat/python-audit-workflowpin.Test plan
python3 -c "import yaml; yaml.safe_load(...)")audit / pip-audit,audit / bandit,audit / CycloneDX SBOMall resolvepython-audit.yml@mainat the merge commit and pass.