Conversation
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
|
Copied over design review from the other pr NimishaAwesome! Looks really nice! Only some small changes. Overall:
In the "Delegation" modal:
In the "Add delegates" modal:
Laura
I was going off of form group components, not a dialog, in this context, I think the two different headings don't make sense either, we could just have one "Delegates" title :) LauraAdding to what nimishavijay said, the "Revoke" button should also probably not have an icon, a checkmark with danger styling is always confusing :) Additionally, the user selection dropdown should be full-width and there should be a bit more padding between the explanation text beneath and the buttons, also in the revoke access dialog. |
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
|
For provisioned accounts I would suggest to hide the ui option to create a delegation (and maybe even api wise) for now. We have currently two (soon 3) way how authentication works: 1) by using the password from the user session, 2) static password, 3) master password (which is similar to static password). Case 1: This needs the password of the owner and hence, delegating would only work if the user has been logged in once. That should be the case anyway, however this still seems a bit fragile (think of password change cases, etc). Case 2: Static password should work, but in the current version wa also use the middleware to update the password which probably wont work currently. Case 3: Master password should work but is currently not merged. Community PR that I took over #12442. It needs a bit of polishing and we wanted to move the password updating from the middleware to the factory. |
Mvp for #12403