Skip to content

[stable32] feat: Add memcache_customprefix#58812

Merged
AndyScherzinger merged 1 commit intostable32from
backport/58705/stable32
Apr 20, 2026
Merged

[stable32] feat: Add memcache_customprefix#58812
AndyScherzinger merged 1 commit intostable32from
backport/58705/stable32

Conversation

@kesselb
Copy link
Copy Markdown
Contributor

@kesselb kesselb commented Mar 9, 2026

Summary

Manual backport of #58705

Automated backport failed because of code style / class imports.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kesselb kesselb added this to the Nextcloud 32.0.7 milestone Mar 9, 2026
@kesselb kesselb self-assigned this Mar 9, 2026
@kesselb kesselb requested a review from a team as a code owner March 9, 2026 16:10
@kesselb kesselb requested review from salmart-dev and removed request for a team March 9, 2026 16:10
@kesselb kesselb added bug 3. to review Waiting for reviews labels Mar 9, 2026
@github-actions github-actions Bot changed the title feat: Add memcache_customprefix [stable32] feat: Add memcache_customprefix Mar 9, 2026
@kesselb kesselb force-pushed the backport/58705/stable32 branch from 8afb769 to 31146d6 Compare March 9, 2026 16:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport to stable32 adding a configurable cache key namespace prefix (memcache_customprefix) so multiple Nextcloud instances can share the same Redis/Memcached infrastructure with reduced risk of key collisions and improved support for Redis ACL key prefixing.

Changes:

  • Add support in OC\Memcache\Factory to prepend memcache_customprefix to the computed global cache prefix (including withServerVersionPrefix()).
  • Document the new memcache_customprefix option in config/config.sample.php.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
lib/private/Memcache/Factory.php Prepends memcache_customprefix to the hashed global cache prefix used for local/distributed/locking caches.
config/config.sample.php Adds sample config entry and documentation for memcache_customprefix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/private/Memcache/Factory.php
Comment thread lib/private/Memcache/Factory.php
Comment thread config/config.sample.php
Comment thread lib/private/Memcache/Factory.php
@skjnldsv skjnldsv mentioned this pull request Mar 18, 2026
@skjnldsv skjnldsv mentioned this pull request Mar 26, 2026
13 tasks
Signed-off-by: Martin <31348196+Earl0fPudding@users.noreply.github.com>
@kesselb kesselb force-pushed the backport/58705/stable32 branch from 31146d6 to 51fa552 Compare April 20, 2026 16:17
Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@AndyScherzinger AndyScherzinger merged commit d4545b1 into stable32 Apr 20, 2026
198 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/58705/stable32 branch April 20, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants