Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables ADL-based, unqualified invoke / reflect usage for pro::proxy and pro::proxy_indirect_accessor, aligning the API with the “unqualified swap” style and allowing dispatch/reflector authoring without pro:: qualifiers.
Changes:
- Added ADL-discoverable friend function templates
invokeandreflecttoproxy/proxy_indirect_accessor. - Marked
pro::proxy_invokeandpro::proxy_reflectoverloads as deprecated and updated internal call sites. - Updated unit tests and accessor/formatter helpers to use unqualified
invoke/reflect.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/utils.h | Updates reflection helper to use unqualified reflect. |
| tests/proxy_reflection_tests.cpp | Updates tests to use unqualified reflect. |
| tests/proxy_creation_tests.cpp | Updates tests to use unqualified reflect. |
| include/proxy/v4/proxy.h | Adds friend invoke/reflect, updates internal calls, and deprecates proxy_invoke/proxy_reflect. |
| include/proxy/v4/proxy_macros.h | Updates generated accessors to call unqualified invoke. |
| include/proxy/v4/proxy_fmt.h | Updates {fmt} formatter to call unqualified invoke. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing
pro::proxy_invokeandpro::proxy_reflectare not necessarily defined as global functions. Similar toswap, they can be defined as friend functions to scope their usage. When authoring a dispatch or reflector type, users no longer need to add qualifiers toinvokeorreflectafter this change.Changes
invokeandreflecttopro::proxyandpro::proxy_indirect_accessor, respectively. Their semantics align with the existingpro::proxy_invokeandpro::proxy_reflect.pro::proxy_invokeandpro::proxy_reflectas deprecated.