Skip to content

crypto: add memory tracking for secureContext openssl objects#59051

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
mertcanaltin:mert/crypto-memory-tracking
Apr 9, 2026
Merged

crypto: add memory tracking for secureContext openssl objects#59051
nodejs-github-bot merged 1 commit intonodejs:mainfrom
mertcanaltin:mert/crypto-memory-tracking

Conversation

@mertcanaltin
Copy link
Copy Markdown
Member

@mertcanaltin mertcanaltin commented Jul 13, 2025

add memory tracking for secureContext openssl objects

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jul 13, 2025

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (049664b) to head (e8f94f2).
⚠️ Report is 1856 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59051      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         645      645              
  Lines      189130   189134       +4     
  Branches    37094    37093       -1     
==========================================
- Hits       170339   170332       -7     
+ Misses      11511    11503       -8     
- Partials     7280     7299      +19
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 69.31% <100.00%> (+0.15%) ⬆️
src/crypto/crypto_context.h 100.00% <ø> (ø)
src/crypto/crypto_util.h 75.61% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 23, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Dec 23, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70588/

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 4, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70670/

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71534/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2026
@nodejs-github-bot nodejs-github-bot merged commit 9ec4a61 into nodejs:main Apr 9, 2026
86 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 9, 2026

Landed in 9ec4a61

joyeecheung
joyeecheung reviewed Apr 11, 2026
View reviewed changes
test/cctest/test_node_crypto.cc
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right way to test it: it should be tested either via snapshots, or just not needed.

Copy link
Copy Markdown
Member Author

@mertcanaltin mertcanaltin Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review @joyeecheung , I now edit

Copy link
Copy Markdown
Member Author

@mertcanaltin mertcanaltin Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I open a PR, #62689 , thanks again!

mertcanaltin added a commit to mertcanaltin/node that referenced this pull request Apr 11, 2026
@mertcanaltin
test: remove unnecessary cctest for memory tracking constants
0167688 
Refs: nodejs#59051
@mertcanaltin mertcanaltin mentioned this pull request Apr 11, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mertcanaltin @nodejs-github-bot @addaleax @anonrig @joyeecheung @avivkeller