Skip to content

tools: bump @node-core/doc-kit from 1.0.2 to 1.2.0 in /tools/doc in the doc group#62512

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/tools/doc/doc-9a4af27da3
Open

tools: bump @node-core/doc-kit from 1.0.2 to 1.2.0 in /tools/doc in the doc group#62512
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/tools/doc/doc-9a4af27da3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 30, 2026 •
edited
Loading

Bumps the doc group in /tools/doc with 1 update: @node-core/doc-kit.

Updates @node-core/doc-kit from 1.0.2 to 1.2.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added dependencies Pull requests that update a dependency file. javascript Pull requests that update Javascript code labels Mar 30, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

Review requested:

  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 30, 2026
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tools/doc/doc-9a4af27da3 branch from e4f2a2a to 69ca5a5 Compare April 6, 2026 18:33
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 6, 2026

@avivkeller what's the latest version of doc-kit atm? Also tests failing 🤔

@avivkeller
Copy link
Copy Markdown
Member

avivkeller commented Apr 6, 2026 •
edited
Loading

@avivkeller what's the latest version of doc-kit atm?

1.3.3

Also tests failing 🤔

Flaky tests, unrelated to doc-kit.

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 6, 2026

@avivkeller what's the latest version of doc-kit atm?

1.3.3

Also tests failing 🤔

Flaky tests, unrelated to doc-kit.

Will this PR automatically get updated to 1.3.3?

@kxxt
Copy link
Copy Markdown
Member

kxxt commented Apr 11, 2026

Will this PR automatically get updated to 1.3.3?

IIRC @dependabot recreate will recreate a PR that bumps to latest version.

But since I need a bump to fix make test-only on RISC-V, I opened a PR to bump it manually here: #62686

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 11, 2026

@dependabot recreate

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 11, 2026

Will this PR automatically get updated to 1.3.3?

IIRC @dependabot recreate will recreate a PR that bumps to latest version.

But since I need a bump to fix make test-only on RISC-V, I opened a PR to bump it manually here: #62686

Didn't notice this was a PR managed by Dependabot, I thought we used our own Bot.

@dependabot
tools: bump @node-core/doc-kit in /tools/doc in the doc group
9c735e8 
Bumps the doc group in /tools/doc with 1 update: [@node-core/doc-kit](https://github.com/nodejs/doc-kit).


Updates `@node-core/doc-kit` from 1.0.2 to 1.2.0
- [Commits](https://github.com/nodejs/doc-kit/commits)

---
updated-dependencies:
- dependency-name: "@node-core/doc-kit"
  dependency-version: 1.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: doc
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/tools/doc/doc-9a4af27da3 branch from 69ca5a5 to 9c735e8 Compare April 11, 2026 22:30
@avivkeller
Copy link
Copy Markdown
Member

avivkeller commented Apr 11, 2026

Didn't notice this was a PR managed by Dependabot, I thought we used our own Bot.

We use @nodejs-github-bot when a dependency isn't supported by Dependabot. When we first landed doc-kit, and used git deps, it wasn't supported by Dependabot, now that we release to npm, it is

kxxt
kxxt reviewed Apr 12, 2026
View reviewed changes
tools/doc/package.json
Copy link
Copy Markdown
Member

@kxxt kxxt Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the dependency is bumped to latest, but the PR title and commit message is out of sync, which is a dependabot bug: dependabot/dependabot-core#4652.

@avivkeller avivkeller mentioned this pull request Apr 12, 2026
Open
@avivkeller avivkeller added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 12, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 12, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 12, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72643/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@avivkeller avivkeller avivkeller approved these changes

+1 more reviewer

@kxxt kxxt kxxt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. javascript Pull requests that update Javascript code tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot @ovflowd @avivkeller @kxxt @cjihrig