Draft
Conversation
✅ Deploy Preview for oasisprotocol-cli canceled.
|
peternose
reviewed
Apr 17, 2026
| if err != nil { | ||
| common.Warnf("Warning: failed to query metadata registry: %v\n", err) | ||
| } | ||
| fromOasisscan, err := metadata.EntitiesFromOasisscan(ctx) |
Contributor
There was a problem hiding this comment.
Why do you need data also from Oasis scan?
| {&fromRegistry, ""}, | ||
| {&fromOasisscan, " (from oasisscan)"}, | ||
| } { | ||
| if src.m == nil || *src.m == nil { |
Contributor
There was a problem hiding this comment.
Hm ... 🤔
// Build a lookup map from entity ID to entity name.
fromRegistry, err := metadata.EntitiesFromRegistry(ctx)
if err != nil {
common.Warnf("Warning: failed to query metadata registry: %v\n", err)
}
fromOasisscan, err := metadata.EntitiesFromOasisscan(ctx)
if err != nil {
common.Warnf("Warning: failed to query oasisscan: %v\n", err)
}
entityNameByID := make(map[string]string)
for _, src := range []struct {
m map[types.Address]*metadata.Entity
suffix string
}{
{fromRegistry, ""},
{fromOasisscan, " (oasisscan)"},
} {
for _, ent := range src.m {
id := ent.ID.String()
if _, ok := entityNameByID[id]; ok {
continue
}
entityNameByID[id] = ent.Name + src.suffix
}
}| } | ||
| table := table.New() | ||
| table.Header("Entity ID", "Node ID", "Role") | ||
| table.Header("Entity Name", "Entity ID", "Node ID", "Role") |
Contributor
There was a problem hiding this comment.
Since the entity name is not to be trusted and can be empty, I would not put it in the first column.
|
|
||
| name := entityNameByID[node.EntityID.String()] | ||
| if name == "" { | ||
| name = "unknown" |
Contributor
There was a problem hiding this comment.
I would just use "", as one could have an entity with name unknown.
peternose
reviewed
Apr 17, 2026
| if _, exists := entityNameByID[ent.ID.String()]; exists { | ||
| continue | ||
| } | ||
| entityNameByID[ent.ID.String()] = ent.Name + src.suffix |
Contributor
There was a problem hiding this comment.
If the name is empty, would this produce name " (from oasiscan)"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #633
Vibe coded with qwen3.6.