Conversation
alexcos20
requested review from
andreip136,
bogdanfazakas,
dnsi0,
giurgiur99 and
ndrpp
as code owners
|
/run-security-scan |
alexcos20
left a comment
alexcos20
left a comment
There was a problem hiding this comment.
AI automated code review (Gemini 3).
Overall risk: low
Summary:
This pull request consistently removes the chainId parameter from PersistentStorageGetBucketsCommand and PersistentStorageDeleteFileCommand across the command interfaces, their respective handlers, and HTTP route parsing logic. The change simplifies the API by eliminating a parameter that is presumed to be unnecessary or incorrectly applied to persistent storage operations. The branch name bug/remove_chainId_from_persistent suggests this is a corrective measure to fix an underlying issue or improve clarity.
Comments:
• [INFO][style] It looks like the JSDoc comment /** Ethereum address; only buckets with this stored owner are returned (then filtered by ACL). */ for the owner field was removed along with chainId. This comment seems to describe the owner field's purpose and might still be relevant if owner's functionality hasn't changed. Could you please confirm if this comment was intentionally removed or if it was an accidental deletion during the chainId removal?
2 participants
Remove chainId from persistentStorage commands, as it was not needed