Fix roles getting unselected in ACL tab#1576
Conversation
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1576/2026-04-22_07-32-36/ . |
ferishili
left a comment
There was a problem hiding this comment.
Thanks @Arnei,
I can confirm that the changes work as expected. However, the Access Policy tab currently has a noticeable delay. Click-Actions are applied only after about 1-2 seconds at best, and I also encountered a white page after adding more than three roles with several action (checkbox) changes.
My suggestion would be to move the inline functions into static methods, although I'm not sure whether that would fully resolve the issue.
|
The Access Policy tab seems to have the issues you noticed also on |
In the access policy tab, when adding new roles, old roles would be removed. Basically, changing the roles in some manner would result in wonky behaviour. This patch fixes that, mostly by reverting 9d0a7b2 and making sure the policy key id is more reliable than index.
25ce8c8 to
5f4615f
Compare
Yes, I can confirm that as well, but it seems to me as it works just a little bit smoother! |
In the access policy tab, when adding new roles, old roles would be removed. Basically, changing the roles in some manner would result in wonky behaviour.
This patch fixes that, mostly by reverting 9d0a7b2 and making sure the policy key id is more reliable than index.
How to test
Can be tested as is, with any event. Make sure that #1523 is still fixed as well.