Skip to content

Fix roles getting unselected in ACL tab#1576

Open
Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Arnei:roles-getting-unselected
Open

Fix roles getting unselected in ACL tab#1576
Arnei wants to merge 1 commit intoopencast:r/19.xfrom
Arnei:roles-getting-unselected

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Apr 13, 2026

In the access policy tab, when adding new roles, old roles would be removed. Basically, changing the roles in some manner would result in wonky behaviour.

This patch fixes that, mostly by reverting 9d0a7b2 and making sure the policy key id is more reliable than index.

How to test

Can be tested as is, with any event. Make sure that #1523 is still fixed as well.

@Arnei Arnei added the type:bug Something isn't working label Apr 13, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/admin-interface:pr-1576

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/admin-interface:pr-1576

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

This pull request is deployed at test.admin-interface.opencast.org/1576/2026-04-22_07-32-36/ .
It might take a few minutes for it to become available.

Copy link
Copy Markdown
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arnei,

I can confirm that the changes work as expected. However, the Access Policy tab currently has a noticeable delay. Click-Actions are applied only after about 1-2 seconds at best, and I also encountered a white page after adding more than three roles with several action (checkbox) changes.

My suggestion would be to move the inline functions into static methods, although I'm not sure whether that would fully resolve the issue.

@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Apr 21, 2026

The Access Policy tab seems to have the issues you noticed also on r/19.x I think. Could you confirm?

In the access policy tab, when adding new roles, old roles
would be removed. Basically, changing the roles in some manner would
result in wonky behaviour.

This patch fixes that, mostly by reverting 9d0a7b2
and making sure the policy key id
is more reliable than index.
@Arnei Arnei force-pushed the roles-getting-unselected branch from 25ce8c8 to 5f4615f Compare April 22, 2026 07:32
@ferishili
Copy link
Copy Markdown
Contributor

Could you confirm?

Yes, I can confirm that as well, but it seems to me as it works just a little bit smoother!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants