chore(deps): bump minimum versions for aiohttp, python-dotenv, and Py…#279
chore(deps): bump minimum versions for aiohttp, python-dotenv, and Py…#279curfew-marathon wants to merge 2 commits intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughDependency version constraints updated across multiple configuration files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (69.91%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 69.91% 69.91%
=======================================
Files 140 140
Lines 10764 10764
=======================================
Hits 7526 7526
Misses 3238 3238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
38-38: Add an upper bound foraiohttpto prevent accidental major-version breakage.Line 38 currently allows any future
aiohttpmajor release. The example files constrainaiohttpto<4, and documented breaking changes exist between 3.x and 4.x. For consistency and to reduce upgrade risk for SDK consumers, alignpyproject.tomlwith the same constraint used in examples.Suggested constraint alignment
- "aiohttp>=3.13.4", + "aiohttp>=3.13.4,<4",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 38, Update the aiohttp dependency constraint to prevent accidental major-version upgrades by replacing the loose spec "aiohttp>=3.13.4" with a bounded spec such as "aiohttp>=3.13.4,<4" so the project stays on compatible 3.x releases; locate and edit the dependency entry string "aiohttp>=3.13.4" in pyproject.toml and apply the new constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 38: Update the aiohttp dependency constraint to prevent accidental
major-version upgrades by replacing the loose spec "aiohttp>=3.13.4" with a
bounded spec such as "aiohttp>=3.13.4,<4" so the project stays on compatible 3.x
releases; locate and edit the dependency entry string "aiohttp>=3.13.4" in
pyproject.toml and apply the new constraint.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cf43a2e4-5f77-4ecd-9ea5-751a752e065f
📒 Files selected for processing (3)
example/example1/requirements.txtexample/opentelemetry/requirements.txtpyproject.toml
There was a problem hiding this comment.
Pull request overview
This PR raises minimum dependency versions to avoid known vulnerable releases, aligning the SDK and example requirements with newer, presumably patched versions.
Changes:
- Bump
aiohttpminimum version inpyproject.tomlto>=3.13.4. - Bump
python-dotenvminimum version in example requirements to>=1.2.2. - Update example dependency sets to reflect the new minimums.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pyproject.toml |
Raises the SDK runtime dependency floor for aiohttp. |
example/opentelemetry/requirements.txt |
Raises the example’s python-dotenv floor to a patched version. |
example/example1/requirements.txt |
Updates example pins for aiohttp and python-dotenv to newer minimums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| license="Apache-2.0" | ||
| dependencies = [ | ||
| "aiohttp>=3.9.3", | ||
| "aiohttp>=3.13.4", |
There was a problem hiding this comment.
The repo uses uv sync (see Makefile), but uv.lock is currently inconsistent with this new aiohttp>=3.13.4 requirement: it still lists aiohttp with specifier >=3.9.3 in the openfga-sdk package metadata. Please regenerate/update uv.lock after bumping the minimum version so the lock metadata matches the published requirements.
| license="Apache-2.0" | ||
| dependencies = [ | ||
| "aiohttp>=3.9.3", | ||
| "aiohttp>=3.13.4", |
There was a problem hiding this comment.
PR description mentions bumping Pygments in uv.lock to >=2.20.0, but the current uv.lock still contains pygments version 2.19.2. Either update the lockfile to the intended fixed version (and include it in this PR) or adjust the PR description so it matches what’s actually being changed.
|
Oops, Sorry for merging another PR and introducing conflicts in this one |
Pull request was closed
Raises the minimum allowed versions to exclude known vulnerable releases:
Summary by CodeRabbit