AGENT-1511: Support HA ( 5 control planes) Cluster Topology for OVE NoRegistry#1884
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if [[ "${AGENT_E2E_TEST_BOOT_MODE}" == "ISO_NO_REGISTRY" ]]; then | ||
| if [[ "${AGENT_E2E_TEST_SCENARIO}" != "COMPACT_IPV4" && "${AGENT_E2E_TEST_SCENARIO}" != "5CONTROL_IPV4" ]]; then | ||
| printf "\nInvalid AGENT_E2E_TEST_SCENARIO '%s' for AGENT_E2E_TEST_BOOT_MODE='ISO_NO_REGISTRY'.\n" "${AGENT_E2E_TEST_SCENARIO}" | ||
| printf "When using ISO_NO_REGISTRY boot mode, only 'COMPACT_IPV4' and '5CONTROL_IPV4' are supported.\n" |
There was a problem hiding this comment.
This validation will be later updated as we support more version of OVE
There was a problem hiding this comment.
But do we really need it now? I feel slightly more confused with it
There was a problem hiding this comment.
Its rare that someone else will add an invalid config as we are the only ones who are using the configurations. The validation added because there is exisiting validation for agent automated scenatios.
openshift-ci
Bot
requested review from
andfasano,
bfournie,
rwsu and
sadasu
and removed request for
celebdor and
lranjbar
| } | ||
|
|
||
| menuItem.MustClick() | ||
| time.Sleep(500 * time.Millisecond) |
There was a problem hiding this comment.
Q: why all these sleeps? IIRC there was a default way in go-rod to "slow down" a little bit the operations
| // getControlPlaneCount determines the control plane count based on AGENT_E2E_TEST_SCENARIO | ||
| func getControlPlaneCount() int { | ||
| scenario := os.Getenv("AGENT_E2E_TEST_SCENARIO") | ||
| if strings.HasPrefix(scenario, "5CONTROL") { |
There was a problem hiding this comment.
Adding also 4CONTROL sounds also an easy win
There was a problem hiding this comment.
yes, now that we have the final list of supported cluster topologies, I will update this PR to also support SNO, 3,4 and 5 node HA
2 participants
Support HA ( 5 control planes) Cluster Topology for OVE NoRegistry Flow in dev-scripts and UI Automation