OCPBUGS-74525: OCPBUGS-74526: Remove UserNamespacesPodSecurityStandards and UserNamespacesSupport#2762
OCPBUGS-74525: OCPBUGS-74526: Remove UserNamespacesPodSecurityStandards and UserNamespacesSupport#2762bitoku wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@bitoku: This pull request references Jira Issue OCPBUGS-74525, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (13)
💤 Files with no reviewable changes (13)
📝 WalkthroughWalkthroughThis pull request removes two feature gates: UserNamespacesSupport and UserNamespacesPodSecurityStandards. The removals update feature gate registrations in features.go, the features.md table, multiple FeatureGate manifests for Hypershift and SelfManagedHA profiles, and remove related feature-gate annotations in proto/types files. The test YAML for UserNamespacesPodSecurityStandards is deleted. Remaining feature entries, fields, and manifest structures are otherwise unchanged. 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hello @bitoku! Some important instructions when contributing to openshift/api: |
|
Skipping CI for Draft Pull Request. |
|
@bitoku: This pull request references Jira Issue OCPBUGS-74525, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
|
PR-Agent: could not fine a component named |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6667530-1e26-11f1-9894-8d3e157c037f-0 |
|
/retest |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4eb8e340-1ef0-11f1-9273-49c828a7ffdd-0 |
|
/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-usernamespace |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/437605e0-2129-11f1-8035-7e0764c49893-0 |
|
Assuming we get clean CI signal, this LGTM. /pipeline run |
|
/lgtm |
|
Scheduling tests matching the |
|
/retest |
|
/payload-job periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ba7cc50-23a3-11f1-867c-8820cbf18d3c-0 |
|
/payload-job periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5e3dd390-23bc-11f1-9219-58006376d688-0 |
|
/payload-job periodic-ci-openshift-microshift-release-4.22-periodics-e2e-aws-ovn-ocp-conformance |
|
@bitoku: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/921c9b30-23bf-11f1-9ea6-3630f034002a-0 |
|
@bitoku Looks like this is hung up on merge conflicts and needing the verified label. If you get the merge conflicts resolved I can help with the necessary labels. |
|
@everettraven Thank you. I'm thinking now that we are close to code freeze, and this one is not a release blocker so I'll delay it to 4.23. |
|
Could we get this rebased please? |
…eature gates Both feature gates have been enabled by default since 4.21 and are no longer needed. The userNamespaceLevel field on SecurityContextConstraints is now ungated and always available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/lgtm |
|
Pipeline controller notification The |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Scheduling tests matching the |
|
/retest-required |
|
@JoelSpeed: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@bitoku: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
UserNamespacesPodSecurityStandards dropped in 1.35 kubernetes/kubernetes@e8bd3f6
UserNamespacesSupport enabled by default in 1.33 kubernetes/kubernetes@96c2b81