Skip to content

SPLAT-2649: Added vSphere Day 2 logic to CRDs #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vr4manta wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SPLAT-2649: Added vSphere Day 2 logic to CRDs #2784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
727806d
Added vSphere Day 2 logic to CRDs
vr4manta Mar 27, 2026
43def11
Added vSphere Day 2 tests
vr4manta Apr 2, 2026
7b21e9d
Modified parent logic to not check size, but only changes in existenc…
vr4manta Apr 3, 2026
af78729
Added some ratcheting tests to cover change in min size of vCenters
vr4manta Apr 20, 2026
291a26c
Updated vcenter logic to make sure no server switching occurs
vr4manta Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 135 additions & 0 deletions config/v1/tests/infrastructures.config.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: "Infrastructure"
crdName: infrastructures.config.openshift.io
featureGates:
- -AWSClusterHostedDNSInstall
- -VSphereMultiVCenterDay2
tests:
onCreate:
- name: Should be able to create a minimal Infrastructure
Expand Down Expand Up @@ -1839,3 +1840,137 @@ tests:
value: value*
type: AWS
expectedStatusError: "invalid AWS resource tag value. The string can contain only the set of alphanumeric characters, space (' '), '_', '.', '/', '=', '+', '-', ':', '@'"
- name: Should allow updating other fields with an invalid persisted vcenters array (empty) in spec
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
cloudConfig:
key: config
name: cloud-provider-config
platformSpec:
type: VSphere
vsphere:
vcenters: []
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
cloudConfig:
key: config
name: cloud-provider-config
platformSpec:
type: VSphere
vsphere:
vcenters: []
- name: Should allow keeping an invalid persisted vcenters array (empty) in spec unchanged
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
failureDomains:
- name: fd1
region: region1
server: vcenter1.example.com
topology:
computeCluster: /DC1/host/cluster1
datacenter: DC1
datastore: /DC1/datastore/ds1
networks:
- network1
resourcePool: /DC1/host/cluster1/Resources
zone: zone1
- name: Should allow updating an invalid persisted vcenters array (empty) to a valid value (1 vcenter) in spec
initialCRDPatches:
- op: remove
path: /spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/platformSpec/properties/vsphere/properties/vcenters/minItems
initial: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters: []
updated: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters:
- server: vcenter1.example.com
port: 443
datacenters:
- DC1
expected: |
apiVersion: config.openshift.io/v1
kind: Infrastructure
spec:
platformSpec:
type: VSphere
vsphere:
vcenters:
- server: vcenter1.example.com
port: 443
datacenters:
- DC1
Loading