AO3-6521 Show titles of restricted related works to admins#5259
Closed
talvalin wants to merge 6 commits intootwcode:masterfrom
Closed
AO3-6521 Show titles of restricted related works to admins#5259talvalin wants to merge 6 commits intootwcode:masterfrom
talvalin wants to merge 6 commits intootwcode:masterfrom
Conversation
sarken
changed the title
sarken
changed the title
Bilka2
changed the title
ceithir
reviewed
Jul 10, 2025
Contributor
ceithir
left a comment
ceithir
left a comment
There was a problem hiding this comment.
Test? At first glance, adding a When I am logged in as an admin block to https://github.com/otwcode/otwarchive/blob/master/features/works/work_related.feature#L324 seems like it would do the trick.
| locale: default_locale) | ||
| end | ||
| elsif related_work.restricted? && (download || !logged_in?) | ||
| elsif related_work.restricted? && (download || (!logged_in? && !logged_in_as_admin?)) |
Contributor
There was a problem hiding this comment.
Suggested change
| elsif related_work.restricted? && (download || (!logged_in? && !logged_in_as_admin?)) | |
| elsif related_work.restricted? && (download || guest?) |
Contributor
There was a problem hiding this comment.
Cf
otwarchive/app/controllers/application_controller.rb
Lines 177 to 179 in 4aaf5ea
Contributor
|
Adopted at #5730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6521
Purpose
Fixes a problem where the titles of restricted related works are not shown to admins.
Credit
talvalin
he/him