AO3-7130 Hide non-interactive submit terms in tag work filters#5728
Open
noahbravo wants to merge 3 commits intootwcode:masterfrom
Open
AO3-7130 Hide non-interactive submit terms in tag work filters#5728noahbravo wants to merge 3 commits intootwcode:masterfrom
noahbravo wants to merge 3 commits intootwcode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)?Issue
https://otwarchive.atlassian.net/browse/AO3-7130
Purpose
Fixes a screen reader issue on the tag works filter page where a visually hidden non-interactive submit landmark (
<dt class="landmark">Submit</dt>) was still exposed to assistive technologies.Changes made:
aria-hidden="true"to the two submit landmark<dt>elements inapp/views/works/_filters.html.erb.I noticed that this pattern appears in other parts of the codebase as well, but limited this change to the reported page to keep the fix minimal and low-risk.
Testing Instructions
Follow the reproduction steps in AO3-7130:
https://otwarchive.atlassian.net/browse/AO3-7130
Expected behavior:
Automated tests:
This issue affects screen reader behavior on hidden semantic elements and was validated with manual accessibility testing.
Screenshots
Before:

After:

Credit
Name: Noah Bravo
Pronouns: they/them