(feat): Support PostgreSQL protocol 3.2 negotiation for frontend clients#926
Open
sarajmunjal wants to merge 1 commit intopgdogdev:mainfrom
Open
(feat): Support PostgreSQL protocol 3.2 negotiation for frontend clients#926sarajmunjal wants to merge 1 commit intopgdogdev:mainfrom
sarajmunjal wants to merge 1 commit intopgdogdev:mainfrom
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds frontend-side PostgreSQL protocol 3.2 support to PgDog - addressing #578.
PgDog now accepts 3.2 startup requests, negotiates newer 3.x minor versions down with NegotiateProtocolVersion, reports unsupported pq.* startup options in that response, and returns cancel keys / BackendKeyData in the right shape for the negotiated protocol. Backend connections to PostgreSQL are unchanged.
What changed
Compatibility
3.0 clients continue to work
3.2 clients are accepted directly
newer 3.x minor versions negotiate down to 3.2
non-3.x major versions remain unsupported
Verification
Ran locally: