Fix deprecation warnings across specs and dependencies#202
Open
hasghari wants to merge 4 commits intopusher:masterfrom
Open
Fix deprecation warnings across specs and dependencies#202hasghari wants to merge 4 commits intopusher:masterfrom
hasghari wants to merge 4 commits intopusher:masterfrom
Conversation
This change is backwards-compatible with the minimum version of the mutli_json gem specified in the gemspec file.
The specs were failing locally otherwise
Author
|
Fixes #195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi_jsongem (backwards-compatible with minimum gemspec version)loggergem to development dependencies (required for specs to run locally)Test plan
bundle exec rspecand verify all specs pass with no deprecation warnings🤖 Generated with Claude Code