Skip to content

Exclude virtual environments from doc builds to avoid local sitepacka…#628

Merged
willingc merged 1 commit intopyOpenSci:mainfrom
willingc:local-docs
Apr 17, 2026
Merged

Exclude virtual environments from doc builds to avoid local sitepacka…#628
willingc merged 1 commit intopyOpenSci:mainfrom
willingc:local-docs

Conversation

@willingc
Copy link
Copy Markdown
Collaborator

…ge scan

Copy link
Copy Markdown
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willingc – it makes sense, though for another time I wonder why we have venvs under the doc root in the first place 😅

@willingc
Copy link
Copy Markdown
Collaborator Author

@agriyakhetarpal Thanks for the review. I opened an issue #629 to follow up on your question. I suspect that we need to revisit our .gitignore. Let me look at that before merging this.

@willingc
Copy link
Copy Markdown
Collaborator Author

Closes #629

@agriyakhetarpal detailed explanation in issue. Sphinx's scanning does not exempt the root directory even if gitignore ignores the environments.

@willingc willingc merged commit c9236e9 into pyOpenSci:main Apr 17, 2026
5 checks passed
@willingc willingc deleted the local-docs branch April 17, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants