Open
Conversation
When multiple fits are listed, only the active tab normally receives a full local recalc; other fits keep stale attributes for incoming remote effects. Run recalc for each unique fit in the graph before drawing so speeds and DPS match any tab. Made-with: Cursor
Remove projection engine changes from this branch so it only carries graph behavior updates and remains cleanly composable with fix-projected-on-tab-switch. Made-with: Cursor
Wrap sequential graph recalc loop so projection victims are not marked stale mid-batch, preventing order-dependent mutual projection errors. Made-with: Cursor
Rename temporary variables in expand_reverse_filtered_matchups to make source/target reversal intent explicit and reduce future confusion. Made-with: Cursor
Make reverse matchup expansion rely on graph wrapper type checks instead of direct item class checks so the checkbox consistently adds reverse pairs. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Showing multiple fits in Graph window becomes a mess quickly even for trivial cases when you want to compare how 2 fits perform against each other. This produces N*M graphs which are hard to read even with with color keys.
Solution
Take selections in attacker and target lists into account so only graphs for selected fits are displayed.
If no fit is selected the behavior is unchanged.
Examples:
Selecting attackers
Selecting targets
Selecting attackers and targets
Selecting attackers and targets with reverse matchups