Skip to content

gh-146264: Use static HACL deps for static module builds#146265

Merged
gpshead merged 1 commit intopython:mainfrom
booxter:gh-146264
Apr 11, 2026
Merged

gh-146264: Use static HACL deps for static module builds#146265
gpshead merged 1 commit intopython:mainfrom
booxter:gh-146264

Conversation

@booxter
Copy link
Copy Markdown
Contributor

@booxter booxter commented Mar 21, 2026 •
edited by gpshead
Loading

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Mar 21, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Mar 21, 2026
Open
@gpshead gpshead added the needs backport to 3.14 bugs and security fixes label Apr 11, 2026
@gpshead gpshead merged commit f445d2e into python:main Apr 11, 2026
55 checks passed
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Apr 11, 2026

Thanks @booxter for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2026
@booxter @miss-islington
pythongh-146264: Use static HACL deps for static module builds (pytho…
5dea061 
…nGH-146265)

(cherry picked from commit f445d2e8666c5585d613add075cabe2abc7f972b)

Co-authored-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 11, 2026

GH-148403 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Apr 11, 2026
gpshead pushed a commit that referenced this pull request Apr 11, 2026
@miss-islington @booxter
[3.14] gh-146264: Use static HACL deps for static module builds (GH-1…
d6be9fb 
…46265) (#148403)

gh-146264: Use static HACL deps for static module builds (GH-146265)
(cherry picked from commit f445d2e)

Co-authored-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Static musl build regression (3.14+): duplicate _Py_LibHacl_* symbols from duplicated Modules/_hacl/*.o

2 participants

@booxter @gpshead