tests: use errno.EBADF instead of hardcoded number in _close_file()#148345
Merged
gpshead merged 1 commit intopython:mainfrom Apr 12, 2026
Merged
tests: use errno.EBADF instead of hardcoded number in _close_file()#148345gpshead merged 1 commit intopython:mainfrom
gpshead merged 1 commit intopython:mainfrom
Conversation
…ose_file() Replace the hardcoded `9` check in `Lib/test/test_interpreters/utils.py` with `errno.EBADF`. Using `errno.EBADF` makes the helper portable across platforms with different errno numbering while preserving the intended behavior.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
artemyarulin
changed the title
picnixz
approved these changes
Apr 11, 2026
picnixz
changed the title
picnixz
added
needs backport to 3.13
gpshead
approved these changes
Apr 12, 2026
|
Thanks @artemyarulin for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2026
…ythonGH-148345) test_interpreters: use errno.EBADF instead of hardcoded number in _close_file() Replace the hardcoded `9` check in `Lib/test/test_interpreters/utils.py` with `errno.EBADF`. Using `errno.EBADF` makes the helper portable across platforms with different errno numbering while preserving the intended behavior. (cherry picked from commit cef334fd4c4c24a542ce81ad940b1426b5a7cdbd) Co-authored-by: Artem Yarulin <artem.yarulin@kapteko.com>
|
GH-148410 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2026
…ythonGH-148345) test_interpreters: use errno.EBADF instead of hardcoded number in _close_file() Replace the hardcoded `9` check in `Lib/test/test_interpreters/utils.py` with `errno.EBADF`. Using `errno.EBADF` makes the helper portable across platforms with different errno numbering while preserving the intended behavior. (cherry picked from commit cef334fd4c4c24a542ce81ad940b1426b5a7cdbd) Co-authored-by: Artem Yarulin <artem.yarulin@kapteko.com>
|
GH-148411 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hardcoded
9check inLib/test/test_interpreters/utils.pywitherrno.EBADF.Using
errno.EBADFmakes the helper portable across platforms with different errno numbering while preserving the intended behavior.Didn't create an issue for that as I think it could count as trivial