Skip to content

gh-148402: show caller's location of subprocess.Popen's warnings #148400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stef41 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

gh-148402: show caller's location of subprocess.Popen's warnings #148400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ff6290
gh-000: Add missing stacklevel to warnings.warn() in subprocess.Popen
stef41 Apr 11, 2026
bcc7284
📜🤖 Added by blurb_it.
stef41 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ def __init__(self, args, bufsize=-1, executable=None,
else:
# POSIX
if pass_fds and not close_fds:
warnings.warn("pass_fds overriding close_fds.", RuntimeWarning)
warnings.warn("pass_fds overriding close_fds.", RuntimeWarning, stacklevel=2)
close_fds = True
if startupinfo is not None:
raise ValueError("startupinfo is only supported on Windows "
Expand Down Expand Up @@ -1567,7 +1567,8 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
if handle_list:
if not close_fds:
warnings.warn("startupinfo.lpAttributeList['handle_list'] "
"overriding close_fds", RuntimeWarning)
"overriding close_fds", RuntimeWarning,
stacklevel=2)

# When using the handle_list we always request to inherit
# handles but the only handles that will be inherited are
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-04-11-14-28-56.gh-issue-148402.zey6m1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Add missing ``stacklevel=2`` to two :func:`warnings.warn` calls in
:class:`subprocess.Popen` so that warnings correctly point to the caller's
code instead of ``subprocess.py`` internals.
Loading