Skip to content

Add tests for dgettext, dpgettext, dngettext, and dnpgettext functions#148430

Open
sergiolpzgmz wants to merge 1 commit intopython:mainfrom
sergiolpzgmz:add-dgettext-tests
Open

Add tests for dgettext, dpgettext, dngettext, and dnpgettext functions#148430
sergiolpzgmz wants to merge 1 commit intopython:mainfrom
sergiolpzgmz:add-dgettext-tests

Conversation

@sergiolpzgmz
Copy link
Copy Markdown

Address the TODO in Lib/test/test_gettext.py:13-15

# TODO:
#  - Add new tests, for example for "dgettext"
#  - Tests should have only one assert.

Following the TODO guidance, each test has only one assert.
These functions were not previously tested directly, only indirectly
through other test classes.

@sergiolpzgmz sergiolpzgmz requested a review from tomasr8 as a code owner April 12, 2026 09:38
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot bot commented Apr 12, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Apr 12, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@picnixz picnixz requested a review from StanFromIreland April 12, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant