-
Notifications
You must be signed in to change notification settings - Fork 4
⚡ Optimize plugin detection with concurrent operations #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sunnylqm
merged 1 commit into
master
from
perf-optimize-plugin-detection-15521046730303659627
Apr 14, 2026
+93
−11
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { describe, expect, mock, spyOn, test, beforeEach, afterEach } from 'bun:test'; | ||
|
|
||
| // Mock dependencies before imports | ||
| mock.module('fs-extra', () => ({ | ||
| default: { | ||
| access: async () => {}, | ||
| }, | ||
| })); | ||
|
|
||
| mock.module('i18next', () => ({ | ||
| default: { | ||
| init: () => {}, | ||
| t: (key: string) => key, | ||
| }, | ||
| })); | ||
|
|
||
| import { checkPlugins } from '../src/utils/check-plugin'; | ||
| import * as pluginConfig from '../src/utils/plugin-config'; | ||
|
|
||
| describe('checkPlugins', () => { | ||
| test('should detect plugins concurrently (simulated)', async () => { | ||
| const mockPlugins = [ | ||
| { | ||
| name: 'plugin1', | ||
| bundleParams: { p1: true }, | ||
| detect: async () => { | ||
| await new Promise(resolve => setTimeout(resolve, 100)); | ||
| return true; | ||
| } | ||
| }, | ||
| { | ||
| name: 'plugin2', | ||
| bundleParams: { p2: true }, | ||
| detect: async () => { | ||
| await new Promise(resolve => setTimeout(resolve, 100)); | ||
| return true; | ||
| } | ||
| }, | ||
| { | ||
| name: 'plugin3', | ||
| bundleParams: { p3: true }, | ||
| detect: async () => { | ||
| await new Promise(resolve => setTimeout(resolve, 100)); | ||
| return true; | ||
| } | ||
| } | ||
| ]; | ||
|
|
||
| // Replacing the plugins array in plugin-config | ||
| const originalPlugins = [...pluginConfig.plugins]; | ||
| (pluginConfig.plugins as any).splice(0, pluginConfig.plugins.length, ...mockPlugins); | ||
|
|
||
| const start = Date.now(); | ||
| const result = await checkPlugins(); | ||
| const end = Date.now(); | ||
| const duration = end - start; | ||
|
|
||
| console.log(`Duration with optimized implementation: ${duration}ms`); | ||
|
|
||
| expect(result).toEqual({ | ||
| sentry: false, // default | ||
| sourcemap: false, // default | ||
| p1: true, | ||
| p2: true, | ||
| p3: true | ||
| } as any); | ||
|
|
||
| // Now it's concurrent, so we expect around 100ms. | ||
| // We'll allow some buffer, but it should definitely be less than 250ms. | ||
| expect(duration).toBeLessThan(250); | ||
|
|
||
| // Restore original plugins | ||
| (pluginConfig.plugins as any).splice(0, pluginConfig.plugins.length, ...originalPlugins); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always restore
pluginConfig.pluginsviafinally.At Line 51, global test state is mutated. If an assertion fails before Line 73, cleanup is skipped and later tests may fail for the wrong reason.
Proposed fix
🤖 Prompt for AI Agents