Fix smoke test to use existing CodeOwnership method#157
Merged
Conversation
The smoke test was calling `file_owner_team_names` which doesn't exist. Replace with `for_file` which is the actual API method for getting the owning team of a file.
dduugg
approved these changes
Feb 9, 2026
perryqh
added a commit
that referenced
this pull request
Apr 17, 2026
The x86_64-linux smoke test in CD called CodeOwnership.for_file, which requires config/code_ownership.yml in the CWD. This repo intentionally does not ship that config (removed in e9f29ac), so the step failed with "Can't open config file" on the first real dispatch after #157. Replace the call with CodeOwnership.version, which exercises the cross-compiled Rust native extension (loads the .so, calls into Rust) without depending on a project config — the right check for a platform-gem smoke test. Prior smoke test (pre-#157) called a non-existent method with `|| true`, so it silently no-op'd. #157 switched to a real method and dropped the suppression, exposing the latent missing-config problem once CD next ran on workflow_dispatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
perryqh
added a commit
that referenced
this pull request
Apr 17, 2026
) The x86_64-linux smoke test in CD called CodeOwnership.for_file, which requires config/code_ownership.yml in the CWD. This repo intentionally does not ship that config (removed in e9f29ac), so the step failed with "Can't open config file" on the first real dispatch after #157. Replace the call with CodeOwnership.version, which exercises the cross-compiled Rust native extension (loads the .so, calls into Rust) without depending on a project config — the right check for a platform-gem smoke test. Prior smoke test (pre-#157) called a non-existent method with `|| true`, so it silently no-op'd. #157 switched to a real method and dropped the suppression, exposing the latent missing-config problem once CD next ran on workflow_dispatch. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CD smoke test which was calling a non-existent method.
Problem
The smoke test was calling
CodeOwnership.file_owner_team_names('lib/code_ownership.rb')but this method doesn't exist in the CodeOwnership API.The test had
|| trueat the end so it didn't fail the build, but it was silently erroring:Fix
Replace with
CodeOwnership.for_file('lib/code_ownership.rb')which is the actual API method for getting the owning team of a file.