Improvement/cldsrv 875 integrate shared prettier#6124
Open
benzekrimaha wants to merge 10 commits intodevelopment/9.3from
Open
Improvement/cldsrv 875 integrate shared prettier#6124benzekrimaha wants to merge 10 commits intodevelopment/9.3from
benzekrimaha wants to merge 10 commits intodevelopment/9.3from
Conversation
Contributor
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Review by Claude Code |
benzekrimaha
force-pushed
the
improvement/CLDSRV-875-Integrate-shared-prettier
branch
2 times, most recently
from
e57392c to
e85ae46
Compare
|
|
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Review by Claude Code |
Review by Claude Code |
|
Review by Claude Code |
|
LGTM |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
| @@ -74,85 +78,100 @@ permissions: | |||
| contents: read | |||
| packages: write | |||
There was a problem hiding this comment.
The concurrency group uses pull_request.head.sha, which changes with every new commit pushed to the PR. This means each push creates a different concurrency group, so previous runs won't be canceled — defeating the purpose of cancel-in-progress: true.
Use the PR number (or head_ref) instead so that successive pushes to the same PR cancel prior runs:
```suggestion
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
|
benzekrimaha
force-pushed
the
improvement/CLDSRV-875-Integrate-shared-prettier
branch
from
58c9beb to
902ab8b
Compare
|
|
LGTM |
1 similar comment
|
LGTM |
DarkIsDude
reviewed
Apr 2, 2026
| This will start the developement server, watching for changes and restarting | ||
| as needed. | ||
|
|
||
| ### Formatting |
Contributor
There was a problem hiding this comment.
Then I think we should ignore package.json ?
Contributor
Author
There was a problem hiding this comment.
either add it to the ignore or we inforce the linting in it , it's a choice to make we can check with others what they prefer
| "ft_sse_arn": "cd tests/functional/sse-kms-migration && mocha --reporter mocha-multi-reporters --reporter-options configFile=$INIT_CWD/tests/reporter-config.json -t 10000 cleanup.js arnPrefix.js --exit", | ||
| "lint": "eslint $(git ls-files '*.js')", | ||
| "lint_md": "mdlint $(git ls-files '*.md')", | ||
| "format:changed": "scripts/format-changed.sh", |
Contributor
There was a problem hiding this comment.
Suggested change
| "format:changed": "scripts/format-changed.sh", | |
| "format:check:diff": "scripts/format-changed.sh", |
Maybe ?
Contributor
Author
There was a problem hiding this comment.
tried to keep the same name as the sh , can indeed be changed
Contributor
There was a problem hiding this comment.
the script can be renamed as well
Contributor
There was a problem hiding this comment.
Maybe a quick comment to explain the goal of the script and how it's working ?
|
LGTM |
DarkIsDude
approved these changes
Apr 2, 2026
| "ft_sse_arn": "cd tests/functional/sse-kms-migration && mocha --reporter mocha-multi-reporters --reporter-options configFile=$INIT_CWD/tests/reporter-config.json -t 10000 cleanup.js arnPrefix.js --exit", | ||
| "lint": "eslint $(git ls-files '*.js')", | ||
| "lint_md": "mdlint $(git ls-files '*.md')", | ||
| "format:changed": "scripts/format-changed.sh", |
Contributor
There was a problem hiding this comment.
the script can be renamed as well
maeldonn
reviewed
Apr 8, 2026
benzekrimaha
force-pushed
the
improvement/CLDSRV-875-Integrate-shared-prettier
branch
from
16e46ef to
d8df099
Compare
maeldonn
approved these changes
Apr 20, 2026
| indentation, run formatting before pushing dependency changes: | ||
|
|
||
| ```bash | ||
| yarn format |
In this commit lint.yaml was converted to a reusable workflow using workflow_call removing the separate standalone lint run and keeps lint under the main tests workflow. prettier-diff.sh no longer tries to infer branches using BASE_SHA / BASE_REF / hardcoded defaults.Diff range is now provided by workflow invocation, instead of the script logic. Issue: CLDSRV-875
| lint: | ||
| uses: ./.github/workflows/lint.yaml | ||
| with: | ||
| git-diff-args: ${{ github.event_name == 'push' && format('{0}..{1}', github.event.before, github.sha) || 'HEAD~1..HEAD' }} |
Contributor
There was a problem hiding this comment.
not correct : should run on the diff from "upstream" to now.
for exemple: if we push 1 commit, then another 1 → script must run on the whole diff (2 commits), not just the last one
The previous approach used github.event.before..github.sha for push events, which only covered the commits in the last push. When pushing multiple times to a branch, only the latest push was checked.Now the lint workflow computes the merge base with origin/HEAD (the default branch) so prettier always checks the full branch diff,regardless of how many pushes were made. Issue:CLDSRV-875
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-875